Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approve sdc by Guid #156

Merged
merged 11 commits into from
Feb 7, 2023
Merged

Approve sdc by Guid #156

merged 11 commits into from
Feb 7, 2023

Commits on Feb 6, 2023

  1. first draft added

    @khareRajshree @VamsiSiddu-7
    khareRajshree authored and VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    40cb713 View commit details
    Browse the repository at this point in the history

  2. second draft added

    @khareRajshree @VamsiSiddu-7
    khareRajshree authored and VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    d07f937 View commit details
    Browse the repository at this point in the history

  3. changed the ApproveSdc logic in controllerPubishVolumefn.

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    f824307 View commit details
    Browse the repository at this point in the history

  4. moved the approveSdc logic to nodeProbe fn.

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    242bdd0 View commit details
    Browse the repository at this point in the history

  5. updated values and templates yamls.

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    e1feb73 View commit details
    Browse the repository at this point in the history

  6. Added required unit tests for the approveSdc

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    903baf1 View commit details
    Browse the repository at this point in the history

  7. corrected the default value of approveSDCEnabled

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    1b1b2a0 View commit details
    Browse the repository at this point in the history

  8. removed the extra line in values.yaml

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    d165c93 View commit details
    Browse the repository at this point in the history

  9. add logs and err messages for non-guid restrictedSdcMode

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    74eaf13 View commit details
    Browse the repository at this point in the history

  10. handled the system nil error and changed the node and values yaml

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    5dc533c View commit details
    Browse the repository at this point in the history

  11. fix comments and error messages in values and nodeProbe

    @VamsiSiddu-7
    VamsiSiddu-7 committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    f92a7d9 View commit details
    Browse the repository at this point in the history