Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing linting errors #232

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fixing linting errors #232

merged 1 commit into from
Jan 3, 2024

Conversation

shanmydell
Copy link
Collaborator

@shanmydell shanmydell commented Sep 25, 2023 •
edited
Loading

Description

Fixing linting errors

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

boyamurthy
boyamurthy reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix vetting and formatting issues .

tssushma
tssushma previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

boyamurthy
boyamurthy previously approved these changes Jan 3, 2024
View reviewed changes
@shanmydell shanmydell dismissed stale reviews from boyamurthy and tssushma via 0f176b5 January 3, 2024 08:52
@shanmydell shanmydell force-pushed the feature-liniting-errors branch from 97b4552 to 0f176b5 Compare January 3, 2024 08:52
@boyamurthy boyamurthy force-pushed the feature-liniting-errors branch from d21b8ea to b7ee8f3 Compare January 3, 2024 09:07
@tssushma tssushma self-requested a review January 3, 2024 09:39
tssushma
tssushma approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tssushma tssushma merged commit a375952 into main Jan 3, 2024
@shanmydell shanmydell deleted the feature-liniting-errors branch January 3, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@tssushma tssushma tssushma approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@delldubey delldubey Awaiting requested review from delldubey

@mjsdell mjsdell Awaiting requested review from mjsdell

@nidtara nidtara Awaiting requested review from nidtara

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

@shampavman shampavman Awaiting requested review from shampavman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanmydell @boyamurthy @tssushma