Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds error-checks for general OS errors #238

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Adds error-checks for general OS errors #238

merged 1 commit into from
Oct 25, 2023

Conversation

delldubey
Copy link
Contributor

@delldubey delldubey commented Oct 17, 2023 •
edited by gallacher
Loading

Description

Adds error-checks for general OS errors

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1014

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Tests
  • Cluster Tests

santhoshhs10
santhoshhs10 previously approved these changes Oct 17, 2023
View reviewed changes
@delldubey delldubey merged commit 9e0bb1e into main Oct 25, 2023
3 of 4 checks passed
@shanmydell shanmydell deleted the osStat-errorChecks branch January 31, 2024 15:42
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@delldubey @Sahiba-Gupta
Adds error checks for generous os errors (#238)
21eda8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidtara nidtara nidtara approved these changes

@shanmydell shanmydell shanmydell approved these changes

@santhoshhs10 santhoshhs10 santhoshhs10 left review comments

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@SinuChacko SinuChacko Awaiting requested review from SinuChacko

@shampavman shampavman Awaiting requested review from shampavman

@tssushma tssushma Awaiting requested review from tssushma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delldubey @shanmydell @santhoshhs10 @nidtara