Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go version bump-up #272

Merged
merged 2 commits into from
Feb 23, 2024
Merged

go version bump-up #272

merged 2 commits into from
Feb 23, 2024

Conversation

nitesh3108
Copy link
Contributor

Updating go version to latest available i.e. => 1.22

Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @nitesh3108 , please update go version here as well.
https://github.com/dell/csi-powermax/blob/go-version-bumpup-1.22/csireverseproxy/go.mod#L3

after updating go version, please run "make clean build" so that it will update if there any package updates.

@nitesh3108
Copy link
Contributor Author

hi @nitesh3108 , please update go version here as well. https://github.com/dell/csi-powermax/blob/go-version-bumpup-1.22/csireverseproxy/go.mod#L3

after updating go version, please run "make clean build" so that it will update if there any package updates.

Sure.
its running "go mod tidy" post version update

Copy link
Contributor

@chimanjain chimanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: nitesh3108 <nitesh_rewatkar@dell.com>
Signed-off-by: nitesh3108 <nitesh_rewatkar@dell.com>
@chimanjain chimanjain force-pushed the go-version-bumpup-1.22 branch from eb0c4ca to 8856e6b Compare February 23, 2024 10:28
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delldubey delldubey merged commit 8769da0 into main Feb 23, 2024
3 of 4 checks passed
@nitesh3108 nitesh3108 deleted the go-version-bumpup-1.22 branch February 23, 2024 10:32
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants