Add warning message if an higher k8s version is tested #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coulof
requested review from
atye,
bharadwajrs-dell,
boyamurthy,
delldubey,
mjsdell,
nidtara,
prablr79,
santhoshhs10,
SinuChacko,
shanmydell,
shaynafinocchiaro and
tssushma
as code owners
boyamurthy
approved these changes
Apr 19, 2024
shanmydell
reviewed
Apr 19, 2024
| @@ -210,6 +210,7 @@ function verify_k8s_versions() { | |||
| if [[ ${V} > ${MAX} ]]; then | |||
| error=1 | |||
There was a problem hiding this comment.
@coulof : Should this be unset, else the script will error out
There was a problem hiding this comment.
This error is set the verification as failure, this will not block installation
shanmydell
requested changes
Apr 19, 2024
shanmydell
reviewed
Apr 19, 2024
shanmydell
approved these changes
Apr 25, 2024
Sahiba-Gupta
pushed a commit
that referenced
this pull request
Oct 11, 2024
Co-authored-by: Yamunadevi N Shanmugam <82038610+shanmydell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we are relaxing the constraint on helm installation to higher kubernetes distro, we add the warning message
GitHub Issues
This relates to that PR: dell/helm-charts#410
And ticket : KRV-13492
Checklist:
How Has This Been Tested?
Not tested