Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linters.yaml #288

Merged
merged 1 commit into from
May 22, 2024
Merged

Update linters.yaml #288

merged 1 commit into from
May 22, 2024

Conversation

gallacher
Copy link
Contributor

Description

Update linter version to golangci/golangci-lint-action@v5 for consistency across all CSM repositories.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy merged commit 434c107 into main May 22, 2024
4 checks passed
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@anandrajak1 anandrajak1 deleted the update-linter-version branch October 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants