returns min possible size vol #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyamurthy
requested review from
atye,
bharadwajrs-dell,
delldubey,
mjsdell,
nidtara,
prablr79,
santhoshhs10,
SinuChacko,
shanmydell,
shaynafinocchiaro and
tssushma
as code owners
shanmydell
reviewed
May 24, 2024
service/controller.go
Outdated
| return 0, status.Errorf( | ||
| codes.OutOfRange, | ||
| "bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes) | ||
| log.Warningf("bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes) |
There was a problem hiding this comment.
Requested size (%d bytes) is less than the minimum volume size (%d bytes) supported by PowerMax..
shanmydell
reviewed
May 24, 2024
service/controller.go
Outdated
| codes.OutOfRange, | ||
| "bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes) | ||
| log.Warningf("bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes) | ||
| log.Warning("provisioning vol with minimum volume size...") |
There was a problem hiding this comment.
Proceeding with minimum volume size supported by PowerMax Array ...
shanmydell
previously approved these changes
May 24, 2024
gallacher
requested changes
May 24, 2024
Hi @gallacher , added the unit tests to cover the various volume sizes and added the screen shot for the same. Thank you. |
gallacher
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowing to create volume with minimum supported size.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Unit test with new changes.