Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returns min possible size vol #290

Merged
merged 3 commits into from
May 29, 2024
Merged

returns min possible size vol #290

merged 3 commits into from
May 29, 2024

Conversation

boyamurthy
Copy link
Contributor

@boyamurthy boyamurthy commented May 24, 2024

allowing to create volume with minimum supported size.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1305

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Unit test with new changes.

image

delldubey
delldubey previously approved these changes May 24, 2024
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

return 0, status.Errorf(
codes.OutOfRange,
"bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes)
log.Warningf("bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested size (%d bytes) is less than the minimum volume size (%d bytes) supported by PowerMax..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

codes.OutOfRange,
"bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes)
log.Warningf("bad capacity: requested minimum size (%d bytes) is less than the minimum volume size (%d bytes)", minSizeBytes, MinVolumeSizeBytes)
log.Warning("provisioning vol with minimum volume size...")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proceeding with minimum volume size supported by PowerMax Array ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

shanmydell
shanmydell previously approved these changes May 24, 2024
@boyamurthy boyamurthy dismissed stale reviews from shanmydell and delldubey via 610d7f4 May 24, 2024 09:24
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the testing that was performed to validate this fix. Have unit tests been put in place to test various scenarios around volume size? If not, please ensure they are in. Not just happy path. Thanks.

@boyamurthy
Copy link
Contributor Author

Please document the testing that was performed to validate this fix. Have unit tests been put in place to test various scenarios around volume size? If not, please ensure they are in. Not just happy path. Thanks.

Hi @gallacher , added the unit tests to cover the various volume sizes and added the screen shot for the same. Thank you.

Copy link
Contributor

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy merged commit f0e5b79 into main May 29, 2024
4 checks passed
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@anandrajak1 anandrajak1 deleted the bug_minSizeErr branch October 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants