Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/minimal CRD #318

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Feature/minimal CRD #318

merged 5 commits into from
Sep 9, 2024

Conversation

harishp8889
Copy link
Contributor

@harishp8889 harishp8889 commented Aug 12, 2024 •
edited
Loading

Description

Implemented required changes for the minimal manifests.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1449

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

  1. Tested by running in the kubernetes cluster
  2. Ran unit tests

@harishp8889 harishp8889 self-assigned this Aug 12, 2024
@harishp8889 harishp8889 changed the title Feature/minimal crd poc Feature/minimal CRD Sep 4, 2024
@harishp8889
Fixed lint issues
2604de6 
Signed-off-by: Harish P <harish_p4@dell.com>
@harishp8889
fixed lint issues
eb5dd83 
Signed-off-by: Harish P <harish_p4@dell.com>
@harishp8889 harishp8889 marked this pull request as ready for review September 4, 2024 12:34
@harishp8889 harishp8889 merged commit d520aa4 into main Sep 9, 2024
5 checks passed
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
@harishp8889 @Sahiba-Gupta
Feature/minimal CRD (#318)
5e758c8 
* updated code for minimal manifest

* Added configmap to read array details

* Fixed lint issues

Signed-off-by: Harish P <harish_p4@dell.com>

* fixed lint issues

Signed-off-by: Harish P <harish_p4@dell.com>

---------

Signed-off-by: Harish P <harish_p4@dell.com>
@anandrajak1 anandrajak1 deleted the feature/minimal-crd-poc branch October 17, 2024 18:52
@harishp8889 harishp8889 mentioned this pull request Oct 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meggm meggm meggm approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees

@harishp8889 harishp8889

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harishp8889 @meggm @adarsh-dell