Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offline installer to ignore comments in the manifests. #325

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

rodrigobassil
Copy link
Contributor

Description

Update offline installer to ignore comments in the manifests.

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

./csi-offline-bundle.sh -c

  • Building image manifest file

    Processing files in /root/workspacecsm/csi-powermax/helm-charts/charts/csi-powermax

  • Pulling and saving container images

    dellemc/csipowermax-reverseproxy:v2.10.0
    dellemc/csi-powermax:v2.11.0
    dellemc/csm-authorization-sidecar:v1.11.0
    dellemc/dell-csi-migrator:v1.5.0
    dellemc/dell-csi-node-rescanner:v1.4.0
    dellemc/dell-csi-replicator:v1.9.0
    dellemc/podmon:v1.10.0
    registry.k8s.io/sig-storage/csi-attacher:v4.6.1
    registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.12.1
    registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.10.1
    registry.k8s.io/sig-storage/csi-provisioner:v5.0.1
    registry.k8s.io/sig-storage/csi-resizer:v1.11.1
    registry.k8s.io/sig-storage/csi-snapshotter:v8.0.1

  • Copying necessary files

/root/workspacecsm/csi-powermax/helm-charts/charts/csi-powermax
/root/workspacecsm/csi-powermax/dell-csi-helm-installer
/root/workspacecsm/csi-powermax/README.md
/root/workspacecsm/csi-powermax/LICENSE

  • Compressing release

csi-powermax-bundle-2.11.0/
csi-powermax-bundle-2.11.0/helm-charts/
csi-powermax-bundle-2.11.0/helm-charts/charts/
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/Chart.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/Chart.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/values.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/conf/
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/conf/config.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/serviceaccount.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/_helpers.tpl
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/certificate.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/configmap.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/reverseproxy-rbac.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/reverseproxy.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/charts/csireverseproxy/templates/service.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/values.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/templates/
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/templates/node.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/templates/_helpers.tpl
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/templates/csidriver.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/templates/driver-config-params.yaml
csi-powermax-bundle-2.11.0/helm-charts/charts/csi-powermax/templates/controller.yaml
csi-powermax-bundle-2.11.0/LICENSE
csi-powermax-bundle-2.11.0/README.md
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/common.sh
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-attacher-v4.6.1.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-resizer-v1.11.1.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-snapshotter-v8.0.1.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-dell-csi-replicator-v1.9.0.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-node-driver-registrar-v2.10.1.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-external-health-monitor-controller-v0.12.1.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-dell-csi-migrator-v1.5.0.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csi-powermax-v2.11.0.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csipowermax-reverseproxy-v2.10.0.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-podmon-v1.10.0.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-dell-csi-node-rescanner-v1.4.0.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-provisioner-v5.0.1.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csm-authorization-sidecar-v1.11.0.tar
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/verify-csi-powermax.sh
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.md
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/.gitignore
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/README.md
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/csi-install.sh
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/images.manifest
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/verify.sh
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/csi-uninstall.sh
csi-powermax-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.sh

  • Complete

Offline bundle file is: /root/workspacecsm/csi-powermax/csi-powermax-bundle-2.11.0.tar.gz

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigobassil rodrigobassil merged commit 7485ffc into main Aug 29, 2024
5 checks passed
@rodrigobassil rodrigobassil deleted the update_offline_installer branch August 29, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants