Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added make target to build without cache #326

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Added make target to build without cache #326

merged 5 commits into from
Sep 17, 2024

Conversation

francis-nijay
Copy link
Contributor

@francis-nijay francis-nijay commented Sep 17, 2024 •
edited by AkshaySainiDell
Loading

Description

Image build job fails because of no space left on the build machine. This is caused by overlay images created during the build process

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1448

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested build and there are no overlay containers left mounted on the build machine

@francis-nijay
Copy link
Contributor Author

image
Overlay containers are not present after the build is completed

adarsh-dell
adarsh-dell previously approved these changes Sep 17, 2024
View reviewed changes
Copy link

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

donatwork
donatwork previously approved these changes Sep 17, 2024
View reviewed changes
gallacher
gallacher previously approved these changes Sep 17, 2024
View reviewed changes
@francis-nijay francis-nijay merged commit 66d3293 into main Sep 17, 2024
5 checks passed
@anandrajak1 anandrajak1 deleted the build-no-cache branch October 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatwork donatwork donatwork approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@gallacher gallacher Awaiting requested review from gallacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@francis-nijay @donatwork @gallacher @AkshaySainiDell @adarsh-dell