Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker build to remove dependency on build script #333

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Oct 9, 2024

Description

Updates build process for the CSI PowerMax driver and Reverse Proxy with following changes. This follows build processes for other drivers and modules:

  • Remove hardcoded golang version dependency from the reverse-proxy image build
  • Remove requirement to have all of the go libraries downloaded separately
  • Remove build.sh file and use common configuration
  • Build the reverse-proxy image as part of the docker targets for building the CSI driver
  • Set defaults using overrides.mk and docker.mk files

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Successfully built all images with these changes
Additional tests executed by @OliverChen557 (see comment below)

@tdawe tdawe marked this pull request as ready for review October 9, 2024 19:43
@bharathsreekanth
Copy link
Contributor

@tdawe As an optimization, is it possible that we don't delete packages immediately after deletion and use it. Ex. driver builds first and downloads 73 packages, and once its done they are removed. reverse-proxy builds next and it also downloads 73 packages, was thinking if we can avoid remove after driver build, then we dont need to pull again. Just a thought.

@OliverChen557
Copy link

OliverChen557 commented Oct 11, 2024

Tests done

  1. Image building was successful using make docker, which is updated on this branch.
  2. The following cert-csi tests were run successfully on the image built:

Environment

# oc version
Client Version: 4.17.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: 4.17.0
Kubernetes Version: v1.30.4

@tdawe tdawe merged commit dc2ab48 into main Oct 11, 2024
5 checks passed
@tdawe tdawe deleted the usr/tdawe/update-build branch October 11, 2024 19:44
@shanmydell
Copy link
Collaborator

@tdawe : Please update GH issue in all PRs, thanks, this has to be added to our release notes, @gallacher : FYR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants