Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerMax Integration test failures #341

Merged
merged 1 commit into from
Oct 17, 2024
Merged

PowerMax Integration test failures #341

merged 1 commit into from
Oct 17, 2024

Conversation

Sahiba-Gupta
Copy link
Contributor

@Sahiba-Gupta Sahiba-Gupta commented Oct 17, 2024 •
edited by AkshaySainiDell
Loading

Description
This change was missed in the previous PR to solve the test cases failure.

GitHub Issue #
dell/csm#1519

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?
Test is already been done in the last PR.

abhi16394
abhi16394 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sahiba-Gupta Sahiba-Gupta merged commit 97fcdc6 into main Oct 17, 2024
5 checks passed
@Sahiba-Gupta Sahiba-Gupta deleted the pvt/pmx_int branch October 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdawe tdawe tdawe approved these changes

@abhi16394 abhi16394 abhi16394 approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sahiba-Gupta @tdawe @abhi16394