Add RestoreSize to VolumeSnapshot #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* get snapshot size from vol size * Update controller.go * add log message * fix quote mark * %d instead of %s * debug log * dumb * use utkarsh math * helm fixes * get rid of hardcoded ns * Update createFromSnap.yaml * no more hardcoded ns * hardcoded ns bad * hard coded n s * kubectl exec syntax update * kubectl exec syntax update * add note about dependent repos * get rid of debug printout * fix unit test target * fmt fixes * controller fmt * gofumpt * remove debug logs * undo makefile changes * Update pvc0.yaml --------- Co-authored-by: root <root@master-1-jkPwn32okjktZ.domain>
jooseppi-luna
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
bpjain2004,
donatwork and
tdawe
as code owners
jooseppi-luna
changed the title
bjiang27
approved these changes
Oct 18, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- Note: this is identical to an earlier PR with unsigned commits --
Currently, when the csi-powermax takes a snapshot of a volume, it does not set a RestoreSize for the snapshot. This PR adds the sizeInBytes field to the snapshot to set the RestoreSize. The following additional work is also done:
kubectl execcommands in helm tests.2vols+restorehelm test to 8194Mi -- even though the requested size of the original volume was 8Gi (8192Mi), PMax rounds to the next cylinder boundary, which gives the pvc an actual size of 8194Mi. A separate doc PR will go up in relation to this.GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Ran unit tests and snaprestore helm test. Cannot currently run cert-csi, because it fails due to the cylinder-boundary rounding. Working on a separate cert-csi PR to fix this, but was instructed by @AronAtDell and @mjsdell to already merge because we have verified the fix with helm tests. Integration tests are currently broken, but I will run them once they are fixed.