Fix nvme block resize #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshaySainiDell
requested review from
abhi16394,
adarsh-dell,
bpjain2004,
donatwork and
tdawe
as code owners
donatwork
approved these changes
Oct 25, 2024
Comment on lines
+2676
to
+2680
| nvmeControllerDevice, err := gofsutil.GetNVMeController(deviceName) | ||
| if err != nil { | ||
| log.Errorf("Failed to rescan device (%s) with error (%s)", deviceName, err.Error()) | ||
| return nil, status.Error(codes.Internal, err.Error()) | ||
| } |
There was a problem hiding this comment.
Why would the GetNVMeController() call fail? Is bailing out the proper handling? Could anything else be done? The error message is inaccurate and can cause problems during troubleshooting. Is it better to indicate that there was a failure to get the device controller?
donatwork
approved these changes
Oct 25, 2024
| log.Errorf("Failed to rescan device (%s) with error (%s)", deviceName, err.Error()) | ||
| return nil, status.Error(codes.Internal, err.Error()) | ||
| } | ||
| if nvmeControllerDevice != "" { |
There was a problem hiding this comment.
So there seems to be a place where nvmeControllerDevice can be empty but GetNVMeController() returns no error. Is this code still then correct?
There was a problem hiding this comment.
For PowerMax, we have two devices: nvme0c0n1 and nvme0n1.
Here, nvme0c0n1 is a controller, but nvme0n1 is not.
The GetNVMeController function processes each device as follows:
- nvme0c0n1 - Successfully returns the controller nvme0.
- nvme0n1 - print logger
Not a valid nvme controller device: nvme0n1and return empty nvmeControllerDevice
rishabhatdell
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix nvme block resize.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration