Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration test README #354

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Update integration test README #354

merged 1 commit into from
Oct 29, 2024

Conversation

jooseppi-luna
Copy link
Contributor

@jooseppi-luna jooseppi-luna commented Oct 29, 2024 •
edited
Loading

Description

Update integration test readme with the following:

  1. Change the file from README to README.md so that markdown works.
  2. Update the steps for running the integration test to ones that actually work.
  3. Add a note on replication test cases that are not currently working due to issues in the tests themselves.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1519

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

This is only a README change. Tested the steps in the README and confirmed that I am able to run the integration tests.

@mjsdell mjsdell self-requested a review October 29, 2024 19:26
mjsdell
mjsdell approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mjsdell mjsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

abhi16394
abhi16394 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jooseppi-luna jooseppi-luna merged commit 3bd9e60 into main Oct 29, 2024
5 checks passed
@jooseppi-luna jooseppi-luna deleted the integration-test-readme-update branch October 29, 2024 19:45
@jooseppi-luna jooseppi-luna mentioned this pull request Oct 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi16394 abhi16394 abhi16394 approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@mjsdell mjsdell mjsdell approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jooseppi-luna @abhi16394 @hoppea2 @mjsdell