Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod #355

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update go.mod #355

merged 1 commit into from
Oct 30, 2024

Conversation

bjiang27
Copy link
Contributor

Description

This PR updates the go.mod

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Successfully built all images with these changes
Ran cert-csi and it passed with 100%

[2024-10-29 21:08:21]  INFO Avg time of a run:   32.11s
[2024-10-29 21:08:21]  INFO Avg time of a del:   12.02s
[2024-10-29 21:08:21]  INFO Avg time of all:     49.89s
[2024-10-29 21:08:21]  INFO During this run 100.0% of suites succeeded

Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabhatdell rishabhatdell merged commit c1b807e into main Oct 30, 2024
5 checks passed
@rishabhatdell rishabhatdell deleted the update-go-mod branch October 30, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants