Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify which secret is for which unisphere in reverseproxy configmap #366

Merged
merged 28 commits into from
Nov 13, 2024

Conversation

jooseppi-luna
Copy link
Contributor

@jooseppi-luna jooseppi-luna commented Nov 11, 2024

Description

The sample secret names used in the sample reverseproxy configmap yaml are unclear. This PR makes it clear which endpoint each secret is for. There is an accompanying doc PR for this clarification here: dell/csm-docs#1370

Additionally, a few unrelated variable names were changed to comply with linting, and I added a unit test to cover the code where I changed the variable name.

GitHub Issues

GitHub Issue #
dell/csm#1568

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Ran unit tests for both driver and reverseproxy. No integration tests run because these changes are not touched by integration tests (there are no code changes).

@jooseppi-luna jooseppi-luna changed the title Krv 29950 Clarify which secret is for which unisphere in reverseproxy configmap Nov 11, 2024
Copy link
Contributor

@abhi16394 abhi16394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jooseppi-luna jooseppi-luna merged commit 9d70b9f into main Nov 13, 2024
5 checks passed
@jooseppi-luna jooseppi-luna deleted the krv-29950 branch November 13, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants