Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSM common base image #427

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use CSM common base image #427

wants to merge 4 commits into from

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Jan 29, 2025

Description

Use the CSM common base image. Advantage is faster image build, being able to build on non RHEL nodes and to be able to build as a non root user.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1691

Checklist:

  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Built images. Installed driver on cluster and ran cert-csi vio tests using xfs to check for any issue with packages.

@donatwork
Copy link
Contributor Author

PR is currently failing due to test coverage threshold of 90%. Current coverage is 80.7%.

@donatwork
Copy link
Contributor Author

Coverage threshold back to 80%.

@santhoshatdell
Copy link
Contributor

@donatwork: One of the tests seems to be failing with race condition. Could you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants