Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReverseProxy Modules #441

Conversation

falfaroc
Copy link

@falfaroc falfaroc commented Feb 3, 2025

Description

Update all go modules to the latest version. Prior to this, the viper decoding was being handled in an outdated way. This PR fixes that and makes it generate across modules that depend on the config decoding.

With this version of viper, when it reads in the config, every key is converted to lowercase and string for simple parsing. Otherwise, if we try to convert to interface{}, a conversion error is given.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1614

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Update and manually ensure/test that the correct modules are being used.

csireverseproxy/go.mod Outdated Show resolved Hide resolved
@falfaroc falfaroc requested a review from lukeatdell February 3, 2025 21:43
@falfaroc falfaroc merged commit 32e4336 into usr/spark/mount-credentials Feb 4, 2025
6 of 7 checks passed
@falfaroc falfaroc deleted the usr/falfaroc/update-reverse-proxy-modules branch February 4, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants