Add unit tests to k8sutils package #446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests to k8sutils package to bring coverage above 90%.
Additionally, some small refactoring to the k8sutils package was performed to return the already initialized kube clientset if one was present. This appears to have been the intended operation, based on the
var *k8sUtils
variable and the logic to return that clientset if it was already set, but becausek8sUtils
was being redefined in the function, it never operated in that manner.GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Built a new image, deployed and validated using
cert-csi certify