csireverseproxy/pkg/k8sutils - UT improvements #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
csireverseproxy/pkg/k8sutils - UT improvements to bring the coverage to > 90%
K8sUtils.go needed some refactoring to enable mocking of functions that rely on a really k8s cluster. Those functions are now injected.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Unit test: ok revproxy/v2/pkg/k8sutils 0.347s coverage: 91.4% of statements
cert-csi (with image built from this branch) :
Tests:
TestCase: VolumeIoSuite
Started: 2025-02-06 17:19:57.780393693 +0000 UTC
Ended: 2025-02-06 17:30:38.373937927 +0000 UTC
Result: SUCCESS
[2025-02-06 17:30:38] INFO Avg time of a run: 626.82s
[2025-02-06 17:30:38] INFO Avg time of a del: 12.01s
[2025-02-06 17:30:38] INFO Avg time of all: 640.59s