Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for file package #450

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Feb 6, 2025

Description

Targets the usr/spark/unit-test-improvements branch, not main.

Code coverage above 90% for this package:

ok      github.com/dell/csi-powermax/v2/pkg/file        0.039s  coverage: 97.9% of statements

Added unit tests for file package

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Ran unit tests

@tdawe tdawe force-pushed the usr/tdawe/file-unit-tests branch from 2511390 to baa0462 Compare February 6, 2025 22:50
@tdawe tdawe merged commit a645171 into usr/spark/unit-test-improvements Feb 7, 2025
6 of 7 checks passed
@tdawe tdawe deleted the usr/tdawe/file-unit-tests branch February 7, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants