Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s - 126 Changes in CSI Powerscale #161

Merged
merged 5 commits into from
Jan 5, 2023
Merged

K8s - 126 Changes in CSI Powerscale #161

merged 5 commits into from
Jan 5, 2023

Conversation

rajkumar-palani
Copy link
Contributor

@rajkumar-palani rajkumar-palani commented Dec 29, 2022 •
edited
Loading

Description

Changes related to installing CSI Power scale Driver on K8s-1.26 version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#597

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Driver Installation and PVC Creation - Sanity

Driver Installation:
image

Nodes:
image

Storage Class:
image

PVC:
image

PVC in OneFS:
image

  • Snapshot - Sanity

image

Snapshot in OneFS:
image

  • PVC From Snapshot - Sanity

image

image

nitesh3108
nitesh3108 reviewed Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@nitesh3108 nitesh3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you have installed Driver and covered sanity.

prablr79
prablr79 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shefali-malhotra
shefali-malhotra reviewed Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revisit the Checklist.

@shanmydell shanmydell linked an issue Jan 5, 2023 that may be closed by this pull request
[FEATURE]: CSM support for Kubernetes 1.26 dell/csm#597
Closed
shefali-malhotra
shefali-malhotra approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shefali-malhotra shefali-malhotra merged commit 3144856 into main Jan 5, 2023
@shefali-malhotra shefali-malhotra deleted the k8s-126changes branch January 5, 2023 19:58
@rajkumar-palani rajkumar-palani mentioned this pull request Jan 29, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@prablr79 prablr79 prablr79 approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: CSM support for Kubernetes 1.26
4 participants
@rajkumar-palani @prablr79 @nitesh3108 @shefali-malhotra