Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication: Target NFS exports are not deleted even though target directories are deleted #192

Merged
merged 4 commits into from
May 5, 2023

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented May 3, 2023

Description

  1. Delete the NFS export for the target side PV/directory. Made use of DeleteLocalVolume replication call. This is needed if target PVs are not consumed by PVC/Pod.
  2. During CreateRemoteVolume() call, break the for loop when it succeeds (10 sec performance improvement for each PV creation).

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#782
dell/csm#783

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes (1 test currently fails on main branch)
  • I have not allowed coverage numbers to degenerate (79.6%)
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Verified the target side driver log and target PowerScale cluster that the NFS export for target directory is deleted.
Tested the variations of target PV with and without PVC/Pod on its side.

Copy link
Contributor

@ChristianAtDell ChristianAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There are several steps involved in adding new calls/messages to unit tests. I think, while it's still fresh in your mind, capturing the components needed for that in some notes might be beneficial for all teams working on csi-powerscale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants