Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubi image updated to micro #201

Merged
merged 1 commit into from
Jun 2, 2023
Merged

ubi image updated to micro #201

merged 1 commit into from
Jun 2, 2023

Conversation

nitesh3108
Copy link
Collaborator

@nitesh3108 nitesh3108 commented Jun 1, 2023

Description

  • ubi image updated to micro
  • sidecar update to latest available

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#843

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Build image using ubi-micro as baseimage
--> db11f5287cb
[2/3] STEP 1/3: FROM localhost/csipowerscale-ubimicro:latest AS driver
[2/3] STEP 2/3: COPY --from=builder /go/src/csi-isilon /
--> 64decfb80bf
[2/3] STEP 3/3: ENTRYPOINT ["/csi-isilon"]
--> 32698269154
[3/3] STEP 1/3: FROM 32698269154aa38560f84f63931e77a99e125257d97fd604399552693adfdfd3 AS final
[3/3] STEP 2/3: LABEL vendor="Dell Inc."       name="csi-isilon"       summary="CSI Driver for Dell EMC PowerScale"       description="CSI Driver for provisioning persistent storage from Dell EMC PowerScale"       version="2.7.0"       license="Apache-2.0"
--> 4ce32bb5222
[3/3] STEP 3/3: COPY ./licenses /licenses
[3/3] COMMIT amaas-eos-mw1.cec.lab.emc.com:5028/csi-isilon/isilon:20230601083637
--> f209bd4f610
Successfully tagged xxxxxxxxx/csi-isilon/isilon:20230601083637
f209bd4f61014bd17d8389f734aaa35b3e4dfd9e4a8aea8d436ffb6b1cfdb16d
  • Tested Driver installation along with pvc, pod creation
# kubectl get po -n isilon
NAME                                 READY   STATUS    RESTARTS   AGE
isilon-controller-7ffbd66795-p5prr   6/6     Running   0          2m47s
isilon-node-84s7d                    2/2     Running   0          2m47s
# kubectl get pvc,po
NAME                             STATUS   VOLUME           CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/test-pvc   Bound    k8s-aafb17e602   5Gi        RWO            isilon         115s

NAME               READY   STATUS    RESTARTS   AGE
pod/ngnix-pv-pod   1/1     Running   0          87s

@donatwork
Copy link
Contributor

Wondering if we should have a separate project to build the base image so it is available for other CSI (and CSM?) projects. In this way the base image can be independently scanned so issues can be resolved once.


microcontainer=$(buildah from $1)
micromount=$(buildah mount $microcontainer)
dnf install --installroot $micromount --releasever=8 --nodocs --setopt install_weak_deps=false --setopt=reposdir=/etc/yum.repos.d/ libaio libuuid numactl xfsprogs e4fsprogs nfs-utils -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not require util-linux package

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nfs-utils is enough, these are same packages as earlier, the difference is we are loading them separately using buildah

@nitesh3108
Copy link
Collaborator Author

Wondering if we should have a separate project to build the base image so it is available for other CSI (and CSM?) projects. In this way the base image can be independently scanned so issues can be resolved once.

This is just initial work for the quarter, will do more enhancement next quarter.

Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitesh3108 nitesh3108 merged commit 9bfdc2f into main Jun 2, 2023
@nitesh3108 nitesh3108 deleted the ubimicro-update branch June 2, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants