Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from UBI minimal to UBI micro #247

Merged
merged 1 commit into from
May 29, 2023
Merged

Migrate from UBI minimal to UBI micro #247

merged 1 commit into from
May 29, 2023

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented May 26, 2023 •
edited
Loading

Description

Changed base image from UBI minimal to UBI micro

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#843

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Pushed nightly image and ran cert-csi
    image

suryagupta4
suryagupta4 previously approved these changes May 29, 2023
View reviewed changes
adarsh-dell
adarsh-dell previously approved these changes May 29, 2023
View reviewed changes
@adarsh-dell adarsh-dell dismissed stale reviews from suryagupta4 and themself via a50cbc1 May 29, 2023 07:14
@adarsh-dell adarsh-dell merged commit dcd5588 into main May 29, 2023
@shanmydell shanmydell deleted the feature-ubi-micro branch January 31, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alankar-verma alankar-verma alankar-verma approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@adarsh-dell adarsh-dell adarsh-dell left review comments

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@prablr79 prablr79 Awaiting requested review from prablr79

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@gilltaran gilltaran Awaiting requested review from gilltaran

@kenivi1 kenivi1 Awaiting requested review from kenivi1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkshaySainiDell @suryagupta4 @adarsh-dell @alankar-verma