Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating go modules to latest #294

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Updating go modules to latest #294

merged 2 commits into from
Dec 6, 2023

Conversation

rishabhatdell
Copy link
Contributor

@rishabhatdell rishabhatdell commented Dec 6, 2023

Description

Updating go modules to latest

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1012

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • cert-csm
    image

suryagupta4
suryagupta4 previously approved these changes Dec 6, 2023
AkshaySainiDell
AkshaySainiDell previously approved these changes Dec 6, 2023
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rishabhatdell rishabhatdell merged commit d62b826 into main Dec 6, 2023
4 of 5 checks passed
@rishabhatdell rishabhatdell deleted the mods_update branch December 6, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants