Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offline bundle instructions from CSI to CSM Operator #295

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

KerryKovacevic
Copy link
Contributor

@KerryKovacevic KerryKovacevic commented Dec 14, 2023

Description

Updated documentation for offline bundle installation from referencing CSI Operator to CSM Operator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1081

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

EvgenyUglov
EvgenyUglov previously approved these changes Dec 14, 2023
@shaynafinocchiaro
Copy link
Contributor

Can you create a github issue and link it here?

Copy link
Contributor

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading image.png…

@KerryKovacevic
Copy link
Contributor Author

@shanmydell Based on the comments left on my other driver PRs, I am assuming your request was meant to refer to "DRIVERNAME" in the script. I have updated that here and will update for the rest of the repos as well.

shanmydell
shanmydell previously approved these changes Dec 19, 2023
delldubey
delldubey previously approved these changes Dec 19, 2023
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PeresKereotubo
PeresKereotubo previously approved these changes Dec 19, 2023
@@ -12,8 +11,8 @@ This includes the following drivers:
* [PowerStore](https://github.com/dell/csi-powerstore)
* [Unity](https://github.com/dell/csi-unity)

As well as the Dell CSI Operator
* [Dell CSI Operator](https://github.com/dell/dell-csi-operator)
The `csm-offline-bundle.sh` script can be used to create a package for offline installation of Dell CSI storage providers for deployment via the CSM Operator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... to create a package for the offline installation of ... "

Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shanmydell shanmydell merged commit caaf1ce into main Dec 20, 2023
4 of 5 checks passed
@shanmydell shanmydell deleted the CSI-to-CSM-operator branch December 20, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants