Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover NVMe TCP addresses individually #302

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Discover NVMe TCP addresses individually #302

merged 4 commits into from
Jan 25, 2024

Conversation

delldubey
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1108

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Cluster Test

@delldubey delldubey force-pushed the discoverNVMEtcp branch 3 times, most recently from 92d9393 to 364ee8d Compare January 23, 2024 12:43
@delldubey delldubey force-pushed the discoverNVMEtcp branch 4 times, most recently from 957aff0 to f44e0d6 Compare January 25, 2024 06:54
boyamurthy
boyamurthy approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@boyamurthy boyamurthy merged commit 2e22835 into main Jan 25, 2024
5 checks passed
alikdell pushed a commit that referenced this pull request Jan 25, 2024
@delldubey @alikdell
Discover NVMe TCP addresses individually (#302)
b299d6a
@shanmydell shanmydell deleted the discoverNVMEtcp branch January 31, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell left review comments

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@boyamurthy boyamurthy boyamurthy approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@gilltaran gilltaran Awaiting requested review from gilltaran

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@kenivi1 kenivi1 Awaiting requested review from kenivi1

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@prablr79 prablr79 Awaiting requested review from prablr79

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@shanmydell shanmydell Awaiting requested review from shanmydell

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@tssushma tssushma Awaiting requested review from tssushma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delldubey @boyamurthy @AkshaySainiDell @adarsh-dell