Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the csm version #313

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Bump the csm version #313

merged 2 commits into from
Feb 21, 2024

Conversation

boyamurthy
Copy link
Contributor

Updating csm version from 2.9.0 to 2.10.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1091

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

delldubey
delldubey previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkshaySainiDell
Copy link
Contributor

Version bump-up is required in Makefile as well.

AkshaySainiDell
AkshaySainiDell approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delldubey
delldubey approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delldubey delldubey merged commit ef05b62 into main Feb 21, 2024
5 checks passed
@santhoshatdell santhoshatdell deleted the bump_csm_version branch September 12, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@delldubey delldubey delldubey approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@atye atye Awaiting requested review from atye

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@EmilyKatdell EmilyKatdell Awaiting requested review from EmilyKatdell

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@gilltaran gilltaran Awaiting requested review from gilltaran

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@kenivi1 kenivi1 Awaiting requested review from kenivi1

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@prablr79 prablr79 Awaiting requested review from prablr79

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@shanmydell shanmydell Awaiting requested review from shanmydell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@tssushma tssushma Awaiting requested review from tssushma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyamurthy @AkshaySainiDell @delldubey