Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offline installer to ignore comments in the manifests. #340

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Update offline installer to ignore comments in the manifests. #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dell-csi-helm-installer/csi-offline-bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ run_command() {
# build_image_manifest
# builds a manifest of all the images referred to by the helm chart
build_image_manifest() {
local REGEX_COMMENTS="(#.*)"
local REGEX="([-_./:A-Za-z0-9]{3,}):([-_.A-Za-z0-9]{1,})"

status "Building image manifest file"
Expand All @@ -82,7 +83,7 @@ build_image_manifest() {
# - search all files in a diectory looking for strings that make $REGEX
# - exclude anything with double '//'' as that is a URL and not an image name
# - make sure at least one '/' is found
find "${D}" -type f -exec egrep -oh "${REGEX}" {} \; | egrep -v '//' | egrep '/' >> "${IMAGEMANIFEST}.tmp"
find "${D}" -type f -exec egrep -v "${REGEX_COMMENTS}" {} \; | egrep -oh "${REGEX}"| egrep -v '//' | egrep '/' >> "${IMAGEMANIFEST}.tmp"
fi
done

Expand Down