Changes to support sync replication for Powerstore #348
Conversation
rajendraindukuri
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
donatwork and
santhoshatdell
as code owners
Addressed |
| @@ -302,15 +318,24 @@ func (s *Service) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest | |||
| if apiError, ok := err.(gopowerstore.APIError); ok && apiError.NotFound() { | |||
| log.Infof("Volume group with name %s not found, creating it", vgName) | |||
|
|
|||
| // Attribute that indicates whether snapshot sets of the volumegroup will be write-order consistent. | |||
| isWriteOrderConsistent := false | |||
There was a problem hiding this comment.
This will make write-order-consistent to be false for ASYNC mode while the API/UI's enables it by default for volume group creation.
CC @alankar-verma
There was a problem hiding this comment.
How about enabling it (sending true) irrespective of the mode?
There was a problem hiding this comment.
Hi @santhoshatdell Currently for async we are not passing is-write-consistent ... so by default the value is going as false due to boolean default value (though from API perspective by default it is true ). For Sync, it should be true always so used this variable to pass as true.. Can we discuss on this and handle as part of upcoming PR s ?
| // Zero indicates value zero for RPO | ||
| Zero = "Zero" | ||
| // Metro indicates Metro mode | ||
| Metro = "METRO" |
There was a problem hiding this comment.
'MetroMode' - to be consistent with other mode names? Or an enum that defines the modes.
lukeatdell
dismissed
their stale review
please address comments by @santhoshatdell
Description
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Ran unit tests and the results look good
Ran sanity to check Sync replication is working as expected. ensured the following scenarios
Details with screenshots are captured and attached as part of 28497