Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dell client and modules #368

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Update Dell client and modules #368

merged 5 commits into from
Oct 29, 2024
+263 −451

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Oct 29, 2024 •
edited
Loading

Description

Update of the Go client and modules.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Installed test image built with the updated modules. Ran cert-csi test suites volume-creation and provisioning. Used NVMe protocol to get more NVMe testing. Will do more testing when the Replication module is updated.

santhoshatdell
santhoshatdell requested changes Oct 29, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
santhoshatdell
santhoshatdell approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@santhoshatdell santhoshatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test results before merging.

@donatwork donatwork marked this pull request as ready for review October 29, 2024 17:04
@donatwork donatwork merged commit f394323 into main Oct 29, 2024
5 checks passed
@donatwork donatwork deleted the csm112-modules-update branch October 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@lukeatdell lukeatdell Awaiting requested review from lukeatdell

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell

@alikdell alikdell Awaiting requested review from alikdell

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donatwork @shaynafinocchiaro @santhoshatdell