Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goiscsi version #131

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Update goiscsi version #131

merged 1 commit into from
Jan 24, 2023

Conversation

panigs7
Copy link
Collaborator

@panigs7 panigs7 commented Jan 23, 2023

Description

Update goiscsi library version to use the latest from main

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Sanity test
image
image

Test Pod using iscsi pvc
image

@rajendraindukuri rajendraindukuri merged commit 0514948 into main Jan 24, 2023
@mjsdell mjsdell deleted the goiscsi-version-update branch October 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandak2 bandak2 bandak2 approved these changes

@rensyct rensyct rensyct approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panigs7 @bandak2 @rensyct @rajendraindukuri @karthikk92