Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove checks warning #206

Merged
merged 3 commits into from
May 14, 2024
Merged

Add remove checks warning #206

merged 3 commits into from
May 14, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented May 13, 2024 •
edited
Loading

Description

Add remove checks warning

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1285

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@suryagupta4 suryagupta4 self-assigned this May 13, 2024
@suryagupta4 suryagupta4 marked this pull request as ready for review May 13, 2024 05:55
@rajendraindukuri rajendraindukuri self-requested a review May 14, 2024 07:59
@adarsh-dell adarsh-dell merged commit 761891b into main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@atye atye Awaiting requested review from atye atye is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees

@suryagupta4 suryagupta4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suryagupta4 @rajendraindukuri @adarsh-dell