Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch host ip when lookup address fails #210

Merged
merged 1 commit into from
May 24, 2024

Conversation

suryagupta4
Copy link
Contributor

Description

This PR adds logic to fetch the host ip using hostname -i command when lookup address fails. With this change, correct host address is getting added to the NFS export list and mount is success.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1306

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Verified by creating an NFS test pod consuming the file system, mount was successful, and pod went into Running state.

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suryagupta4 suryagupta4 merged commit f3b9756 into release-v2.10.1 May 24, 2024
1 check passed
@mjsdell mjsdell deleted the bug-1306-get-host-ip branch October 17, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants