Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non GA version check #214

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Add non GA version check #214

merged 2 commits into from
Jun 24, 2024

Conversation

bharathsreekanth
Copy link
Contributor

@bharathsreekanth bharathsreekanth commented Jun 20, 2024

Description

Update Helm installer to detect unreleased (alpha/beta) Kubernetes releases and prompt the user for acknowledgement before proceeding with installation.

| GitHub Issue # |
| (dell/csm#1325) |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested the regex outside with varying combinations to ensure that it returns what is expected.
  • Tested by hardcoding different versions of the strings and attempting the install to ensure alpha/beta versions ask for user acknowledgement.

Copy link
Contributor

@AronAtDell AronAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bharathsreekanth bharathsreekanth merged commit 69e5844 into main Jun 24, 2024
4 checks passed
@bharathsreekanth bharathsreekanth deleted the sreekb/krv-25257 branch June 24, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants