Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basicsystem info usage for probe to reduce authentication calls #224

Merged

Conversation

sharmilarama
Copy link
Contributor

@sharmilarama sharmilarama commented Aug 7, 2024

Description

CSM Unity was using login API , updating that to use BasicSystemInfo API to reduce the authentication requests to check array liveness probe

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1415

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Ran tests for 4 hours with the health monitor enabled and encountered no 401 errors.

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atye
Copy link
Contributor

atye commented Aug 14, 2024

Can a unit test be added?

@AkshaySainiDell
Copy link
Contributor

Can a unit test be added?

We’ve made some tweaks to improve how we probe the array. Instead of using Authenticate, we’re now calling BasicSystemInfo which does not require any session. The outcome of the probe remains the same, so our existing unit tests should cover us.

@AkshaySainiDell AkshaySainiDell merged commit e1645ae into main Aug 14, 2024
3 of 4 checks passed
@mjsdell mjsdell deleted the feature-session-updated-basicsystem-info-usage-for-probe branch October 17, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants