Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update offline installer to ignore comments in the manifests. #227

Merged
merged 12 commits into from
Aug 29, 2024

Conversation

rodrigobassil
Copy link
Contributor

Description

Update offline installer to ignore comments in the manifests.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

./csi-offline-bundle.sh -c

  • Building image manifest file

    Processing files in /root/workspacecsm/csi-unity/helm-charts/charts/csi-unity

  • Pulling and saving container images

    dellemc/csi-unity:v2.11.0
    dellemc/podmon:v1.10.0
    registry.k8s.io/sig-storage/csi-attacher:v4.6.1
    registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.12.1
    registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.10.1
    registry.k8s.io/sig-storage/csi-provisioner:v5.0.1
    registry.k8s.io/sig-storage/csi-resizer:v1.11.1
    registry.k8s.io/sig-storage/csi-snapshotter:v8.0.1

  • Copying necessary files

/root/workspacecsm/csi-unity/helm-charts/charts/csi-unity
/root/workspacecsm/csi-unity/dell-csi-helm-installer
/root/workspacecsm/csi-unity/README.md
/root/workspacecsm/csi-unity/LICENSE

  • Compressing release

csi-unity-bundle-2.11.0/
csi-unity-bundle-2.11.0/helm-charts/
csi-unity-bundle-2.11.0/helm-charts/charts/
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/Chart.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/values.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/node.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/_helpers.tpl
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/csidriver.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/driver-config-params.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/controller.yaml
csi-unity-bundle-2.11.0/LICENSE
csi-unity-bundle-2.11.0/README.md
csi-unity-bundle-2.11.0/dell-csi-helm-installer/
csi-unity-bundle-2.11.0/dell-csi-helm-installer/common.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csi-unity-v2.11.0.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-attacher-v4.6.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-resizer-v1.11.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-snapshotter-v8.0.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-node-driver-registrar-v2.10.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-external-health-monitor-controller-v0.12.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-podmon-v1.10.0.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-provisioner-v5.0.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.md
csi-unity-bundle-2.11.0/dell-csi-helm-installer/.gitignore
csi-unity-bundle-2.11.0/dell-csi-helm-installer/verify-csi-unity.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/README.md
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-install.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.manifest
csi-unity-bundle-2.11.0/dell-csi-helm-installer/verify.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-uninstall.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.sh

  • Complete

Offline bundle file is: /root/workspacecsm/csi-unity/csi-unity-bundle-2.11.0.tar.gz

@shaynafinocchiaro
Copy link
Contributor

Do the comments have any impact on the code compiling?

@rodrigobassil
Copy link
Contributor Author

Do the comments have any impact on the code compiling?

@shaynafinocchiaro no impact on the code compiling.

@rodrigobassil rodrigobassil merged commit 577fb0c into main Aug 29, 2024
5 checks passed
@rodrigobassil rodrigobassil deleted the update_offline_installer branch August 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants