Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added no cache buildAdded make target to build without cache #229

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

francis-nijay
Copy link
Collaborator

Description

Image build job fails because of no space left on the build machine. This is caused by overlay images created during the build process

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1448

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested build and there are no overlay containers left mounted on the build machine

harishp8889
harishp8889 previously approved these changes Sep 9, 2024
@@ -46,6 +46,14 @@ podman-push: download-csm-common go-build
$(eval include csm-common.mk)
sh build.sh --baseubi $(DEFAULT_BASEIMAGE) --goimage $(DEFAULT_GOIMAGE) --push

podman-build-no-cache: download-csm-common go-build
$(eval include csm-common.mk)
sh build.sh --baseubi $(DEFAULT_BASEIMAGE) --goimage $(DEFAULT_GOIMAGE) --no-cache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reach --no-cache in the build script it may require some changes, Please check the same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@francis-nijay
Copy link
Collaborator Author

image
Overlay containers are not present after the build id completed

karthikk92
karthikk92 previously approved these changes Sep 11, 2024
karthikk92
karthikk92 previously approved these changes Sep 17, 2024
@francis-nijay francis-nijay merged commit 9ff622e into main Sep 17, 2024
5 checks passed
@mjsdell mjsdell deleted the build-no-cache branch October 17, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants