-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added no cache buildAdded make target to build without cache #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis-nijay
requested review from
atye,
bandak2,
Deepak-Ghivari,
karthikk92,
panigs7,
rajendraindukuri and
shaynafinocchiaro
as code owners
September 6, 2024 07:54
harishp8889
previously approved these changes
Sep 9, 2024
harishp8889
reviewed
Sep 9, 2024
@@ -46,6 +46,14 @@ podman-push: download-csm-common go-build | |||
$(eval include csm-common.mk) | |||
sh build.sh --baseubi $(DEFAULT_BASEIMAGE) --goimage $(DEFAULT_GOIMAGE) --push | |||
|
|||
podman-build-no-cache: download-csm-common go-build | |||
$(eval include csm-common.mk) | |||
sh build.sh --baseubi $(DEFAULT_BASEIMAGE) --goimage $(DEFAULT_GOIMAGE) --no-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reach --no-cache
in the build script it may require some changes, Please check the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
karthikk92
previously approved these changes
Sep 11, 2024
rajendraindukuri
previously approved these changes
Sep 12, 2024
francis-nijay
dismissed stale reviews from rajendraindukuri and karthikk92
via
September 17, 2024 12:05
eb68a5b
karthikk92
previously approved these changes
Sep 17, 2024
karthikk92
approved these changes
Sep 17, 2024
rajendraindukuri
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image build job fails because of no space left on the build machine. This is caused by overlay images created during the build process
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration