Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gobrick to latest commit #232

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update gobrick to latest commit #232

merged 1 commit into from
Oct 15, 2024

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Oct 15, 2024 •
edited
Loading

Description

Update gobrick to latest commit.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1447
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the fix with unity driver and validated that the wwids are getting removed from the /etc/multipath/wwids file
    image
    image

@AkshaySainiDell AkshaySainiDell merged commit b6fed8b into main Oct 15, 2024
5 checks passed
@mjsdell mjsdell deleted the update-gobrick branch October 17, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkshaySainiDell @rajendraindukuri @suryagupta4 @adarsh-dell