Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common base image #57

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Use common base image #57

merged 1 commit into from
Nov 10, 2023

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Nov 9, 2023

Description

Use common base image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1031

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built image using common base image

@tdawe tdawe merged commit eaef914 into main Nov 10, 2023
3 of 4 checks passed
@tdawe tdawe deleted the use-common-base-image branch November 10, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AronAtDell AronAtDell AronAtDell approved these changes

@gallacher gallacher gallacher approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdawe @gallacher @AronAtDell