Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UBI Dependencies #75

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update UBI Dependencies #75

merged 1 commit into from
Jun 10, 2024

Conversation

Sahiba-Gupta
Copy link
Contributor

@Sahiba-Gupta Sahiba-Gupta commented Jun 6, 2024 •
edited
Loading

This PR updates the UBI micro dependencies.

| GitHub Issue # |
dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

For now I have tested this change locally ( by running make docker ) and verified that both images have been created and rpm is added.

@Sahiba-Gupta
Copy link
Contributor Author

run e2e test

@Sahiba-Gupta Sahiba-Gupta merged commit 09cb32d into main Jun 10, 2024
4 checks passed
@anandrajak1 anandrajak1 deleted the Update_ubi_dependencies branch October 17, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandrajak1 anandrajak1 anandrajak1 approved these changes

@donatwork donatwork donatwork approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sahiba-Gupta @donatwork @anandrajak1