Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONT DELETE - *Add tabs to improve readability* #1240

Closed
wants to merge 10 commits into from
Closed

Conversation

coulof
Copy link
Collaborator

@coulof coulof commented Aug 29, 2024

Description

Add tabs to improve readability for PowerStore.

Partially solves the issue as it has to be done for others too.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1444
Relates to PR #1237

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Aug 29, 2024

Test Results

76 tests  ±0   76 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b352822. ± Comparison against base commit 41b59b4.

♻️ This comment has been updated with latest results.

@coulof coulof mentioned this pull request Aug 29, 2024
5 tasks
@sharmilarama
Copy link
Contributor

Is there a plan to update this everywhere else?

Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure this PR addresses these changes holistically across all of the documentation. Thanks.

@coulof
Copy link
Collaborator Author

coulof commented Sep 6, 2024

Changes are holistically and it has quite a few other improvements, typos corrections,etc.

@sharmilarama, @gallacher & @shanmydell could you please review asap so I won't have to fight the rebase ;-)

Thx.

Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include changes for PowerScale, PowerFlex, and Unity to drive consistency.

@coulof
Copy link
Collaborator Author

coulof commented Sep 17, 2024

@gallacher, IMHO it makes no sense to do the same for Unity, PowerScale and PowerFlex.

I let you decide to close without or without merging the PR.

@anandrajak1
Copy link
Contributor

This will be handled as part of CSM 1.13 doc restructure

@anandrajak1 anandrajak1 changed the title Add tabs to improve readability DONT DELETE - *Add tabs to improve readability* Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants