Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note for Unity not qualified with Openshift Virtualization Suite #1243

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Add note for Unity not qualified with Openshift Virtualization Suite #1243

merged 5 commits into from
Sep 4, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Sep 2, 2024 •
edited
Loading

Description

Add note for Unity not qualified with OpenShift Virtualization Suite

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

image

@suryagupta4 suryagupta4 self-assigned this Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

Test Results

76 tests  ±0   76 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit a97ebdd. ± Comparison against base commit ab5998d.

♻️ This comment has been updated with latest results.

shefali-malhotra
shefali-malhotra approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suryagupta4
Copy link
Contributor Author

@gallacher: Can you please review this PR? Thanks

gallacher
gallacher reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't call things out we don't support with a banner like this. Please ensure we maintain consistency across the documentation.

@suryagupta4 suryagupta4 merged commit ebcacbc into main Sep 4, 2024
7 checks passed
@suryagupta4 suryagupta4 deleted the unity-openshift-vertualization branch September 4, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher left review comments

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@shanmydell shanmydell shanmydell approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@atye atye Awaiting requested review from atye

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@mgandharva mgandharva Awaiting requested review from mgandharva

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958

@sharont58 sharont58 Awaiting requested review from sharont58

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

Assignees

@suryagupta4 suryagupta4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@suryagupta4 @gallacher @sharmilarama @shanmydell @shefali-malhotra @rishabhatdell