Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Issue of CSM Installation Wizard Page #1246

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

WilsonRadadia20
Copy link
Contributor

Description

  1. Fixed the rendering issue of the CSM Installation Wizard page for latest version [0.134.1] of Hugo.
  2. The older version [0.120.3] it was working fine but for newer versions from 0.123.0 to latest it was having issues of header and footer.
  3. Upgraded the latest Hugo version in deploy.yaml file in GitHub workflows.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1452

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Sep 6, 2024

Test Results

76 tests  ±0   76 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b3b96c3. ± Comparison against base commit ebcacbc.

Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Wilson! Changes look good.

@WilsonRadadia20
Copy link
Contributor Author

Before modifying the CSM Installation Page it was opening to new page, but now it is opening in the same page so there were some issues related to header and footer. So, that is now resolved.

Before modifying the CSM Installation Page:
image-2024-09-04-14-06-52-752 (1)
After modifying the CSM Installation Page:
image-2024-09-06-03-44-02-301

@WilsonRadadia20 WilsonRadadia20 merged commit d0be9b0 into main Sep 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants