-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SDC install an option in Install Wizard #1262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarp20
requested review from
gallacher,
mjsdell,
prablr79,
rajkumar-palani,
AronAtDell and
sharmilarama
as code owners
September 23, 2024 10:10
falfaroc
approved these changes
Sep 26, 2024
Rebase changes. |
kumarp20
requested review from
tdawe,
xuluna,
harshitap26 and
bharathsreekanth
September 27, 2024 12:52
kumarp20
force-pushed
the
wizard-sdc-optional
branch
from
September 27, 2024 13:09
c454ace
to
4a5e4b0
Compare
tdawe
reviewed
Sep 27, 2024
content/docs/deployment/csminstallationwizard/src/static/js/ui-functions.js
Outdated
Show resolved
Hide resolved
tdawe
approved these changes
Sep 30, 2024
bharathsreekanth
approved these changes
Sep 30, 2024
tdawe
force-pushed
the
wizard-sdc-optional
branch
from
October 1, 2024 12:23
c394bf5
to
8b4ab0a
Compare
sharmilarama
approved these changes
Oct 1, 2024
tdawe
force-pushed
the
wizard-sdc-optional
branch
from
October 1, 2024 13:05
079b759
to
7aa6229
Compare
tdawe
force-pushed
the
wizard-sdc-optional
branch
from
October 1, 2024 13:09
7aa6229
to
b076333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new option to allow user to specify whether or not SDC should be installed. If SDC installation is not selected, a note links to the documentation for manual install of SDC and mentions that SDC is required for block storage.
The existing renameSDC and approve SDC options remain unaffected by this change.
Added an alert when approveSDC is not selected instructing user to manually approve SDC.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: