Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SDC install an option in Install Wizard #1262

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Conversation

kumarp20
Copy link
Collaborator

@kumarp20 kumarp20 commented Sep 23, 2024

Description

Added a new option to allow user to specify whether or not SDC should be installed. If SDC installation is not selected, a note links to the documentation for manual install of SDC and mentions that SDC is required for block storage.
The existing renameSDC and approve SDC options remain unaffected by this change.
Added an alert when approveSDC is not selected instructing user to manually approve SDC.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#663

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • [*] Have you tested the changes locally?
  • [*] Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

github-actions bot commented Sep 23, 2024

Test Results

77 tests  +1   77 ✅ +1   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b076333. ± Comparison against base commit 19f4ec3.

♻️ This comment has been updated with latest results.

@falfaroc
Copy link
Contributor

Rebase changes.

@tdawe tdawe merged commit bc1a64f into main Oct 1, 2024
7 checks passed
@tdawe tdawe deleted the wizard-sdc-optional branch October 1, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants