Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Storage Capacity Tracking feature to Powerstore docs #373

Closed
wants to merge 8 commits into from
Closed

Added Storage Capacity Tracking feature to Powerstore docs #373

wants to merge 8 commits into from

Conversation

AkshaySainiDell
Copy link
Contributor

Description

Added Storage Capacity Tracking feature to Powerstore docs

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#483

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review October 28, 2022 09:06
rsedlock1958
rsedlock1958 reviewed Oct 28, 2022
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. There are a couple of minor edits required.

adarsh-dell
adarsh-dell previously approved these changes Oct 31, 2022
View reviewed changes
@adarsh-dell
Copy link
Contributor

adarsh-dell commented Oct 31, 2022 •
edited
Loading

@AkshaySainiDell Do we need to merge these changes to release-1.5 branch instead of main?

spriya-m
spriya-m suggested changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@spriya-m spriya-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @adarsh-dell . The changes should be merged to release-1.5 branch and not to main.
@AkshaySainiDell - Please close this PR and raise a new PR for release-1.5 branch.

@shanmydell
Copy link
Collaborator

@AkshaySainiDell : I have changed the base

@shanmydell shanmydell changed the base branch from main to release-1.5 October 31, 2022 12:51
@shanmydell shanmydell dismissed adarsh-dell’s stale review October 31, 2022 12:51

The base branch was changed.

@AkshaySainiDell AkshaySainiDell force-pushed the update-pstore-storage-capacity-tracking branch from 8d5583b to 894d34e Compare November 2, 2022 03:34
@santhoshatdell santhoshatdell deleted the update-pstore-storage-capacity-tracking branch September 1, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@spriya-m spriya-m spriya-m requested changes

@adarsh-dell adarsh-dell adarsh-dell left review comments

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@gallacher gallacher Awaiting requested review from gallacher

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AkshaySainiDell @adarsh-dell @shanmydell @rsedlock1958 @spriya-m @satyakonduri @mjsdell