-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for Powerstore Install support in csm operator #466
Documentation for Powerstore Install support in csm operator #466
Conversation
| ***Node parameters*** | | ||
| X_CSI_POWERSTORE_ENABLE_CHAP | Set to true if you want to enable iSCSI CHAP feature | No | false | | ||
|
||
4. Execute the following command to create PowerStore custom resource:`kubectl create -f <input_sample_file.yaml>`. The above command will deploy the CSI PowerStore driver in the namespace specified in the input YAML file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "The above" to "This"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| X_CSI_POWERSTORE_ENABLE_CHAP | Set to true if you want to enable iSCSI CHAP feature | No | false | | ||
|
||
4. Execute the following command to create PowerStore custom resource:`kubectl create -f <input_sample_file.yaml>`. The above command will deploy the CSI PowerStore driver in the namespace specified in the input YAML file | ||
- After that the driver should be installed, you can check the condition of driver pods by running `kubectl get all -n <driver-namespace>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "After that" to "Next,"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
**Note** : | ||
1. "Kubelet config dir path" is not yet configurable in case of Operator based driver installation. | ||
2. Also, snapshotter and resizer sidecars are not optional to choose, it comes default with Driver installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete "Also,". Initial uppercase on Snapshotter. Delete "to choose," Add full stop ("." period) after "optional". Replace "it" with "They". Replace "it comes" with "are defaults".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this. Several edits are requiired.
f718735
to
4130a73
Compare
Addressed the review comments. Thanks!! |
771c4fa
to
efbaf6e
Compare
Description
Added documentation for Powerstore install for CSM Operator
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: