Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Powerstore Install support in csm operator #466

Merged

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Feb 20, 2023

Description

Added documentation for Powerstore install for CSM Operator

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#613

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@panigs7 panigs7 changed the title Feature 613 docs for pstore support in csm op Documentation for Powerstore support in csm op Feb 20, 2023
@panigs7 panigs7 changed the title Documentation for Powerstore support in csm op Documentation for Powerstore support in csm operator Feb 20, 2023
@panigs7 panigs7 changed the title Documentation for Powerstore support in csm operator Documentation for Powerstore Install support in csm operator Feb 20, 2023
| ***Node parameters*** |
| X_CSI_POWERSTORE_ENABLE_CHAP | Set to true if you want to enable iSCSI CHAP feature | No | false |

4. Execute the following command to create PowerStore custom resource:`kubectl create -f <input_sample_file.yaml>`. The above command will deploy the CSI PowerStore driver in the namespace specified in the input YAML file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "The above" to "This"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

| X_CSI_POWERSTORE_ENABLE_CHAP | Set to true if you want to enable iSCSI CHAP feature | No | false |

4. Execute the following command to create PowerStore custom resource:`kubectl create -f <input_sample_file.yaml>`. The above command will deploy the CSI PowerStore driver in the namespace specified in the input YAML file
- After that the driver should be installed, you can check the condition of driver pods by running `kubectl get all -n <driver-namespace>`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "After that" to "Next,"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


**Note** :
1. "Kubelet config dir path" is not yet configurable in case of Operator based driver installation.
2. Also, snapshotter and resizer sidecars are not optional to choose, it comes default with Driver installation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete "Also,". Initial uppercase on Snapshotter. Delete "to choose," Add full stop ("." period) after "optional". Replace "it" with "They". Replace "it comes" with "are defaults".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. Several edits are requiired.

@panigs7 panigs7 force-pushed the feature-613-docs-for-pstore-support-in-csm-op branch 2 times, most recently from f718735 to 4130a73 Compare February 21, 2023 12:15
@panigs7
Copy link
Contributor Author

panigs7 commented Feb 21, 2023

I have reviewed this. Several edits are requiired.

Addressed the review comments. Thanks!!

rensyct
rensyct previously approved these changes Feb 21, 2023
karthikk92
karthikk92 previously approved these changes Feb 21, 2023
@panigs7 panigs7 dismissed stale reviews from karthikk92 and rensyct via efbaf6e February 21, 2023 15:46
@panigs7 panigs7 force-pushed the feature-613-docs-for-pstore-support-in-csm-op branch from 771c4fa to efbaf6e Compare February 21, 2023 15:46
@shanmydell shanmydell merged commit b0f913d into release-1.6.0 Feb 21, 2023
@shanmydell shanmydell deleted the feature-613-docs-for-pstore-support-in-csm-op branch February 21, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants