Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing UI improvements #549

Merged
merged 12 commits into from
Mar 30, 2023
Merged

Fixing UI improvements #549

merged 12 commits into from
Mar 30, 2023

Conversation

samihan-dell
Copy link
Contributor

@samihan-dell samihan-dell commented Mar 29, 2023 •
edited
Loading

Description

Following points are fixed as part of this PR:

  1. Added option to Go back to dell csm-docs home page by clicking on Dell logo at top.
  2. Top header color changed to match the header of csm-docs pages
  3. Adjusted the footer position to the bottom.
  4. In the footer added GitHub and slack logos, similar to csm-docs page.
  5. Resolved undefined in CSM installation wizard generated values.yaml
  6. Added Cluster prefix should be 3 letters UI tooltip.
  7. Remove the old CSM properties file for the installation wizard.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#732

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@samihan-dell samihan-dell marked this pull request as ready for review March 29, 2023 11:48
gallacher
gallacher approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

rsedlock1958
rsedlock1958 approved these changes Mar 29, 2023
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No edits are required.

@prablr79
Copy link
Collaborator

@rajkumar-palani can you merge this PR ?

@samihan-dell samihan-dell merged commit 64ba31f into main Mar 30, 2023
@samihan-dell samihan-dell deleted the fixing-ui-improvements branch April 3, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyakonduri satyakonduri satyakonduri approved these changes

@rsedlock1958 rsedlock1958 rsedlock1958 approved these changes

@prablr79 prablr79 prablr79 approved these changes

@gallacher gallacher gallacher approved these changes

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@mgandharva mgandharva Awaiting requested review from mgandharva

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samihan-dell @prablr79 @gallacher @rsedlock1958 @satyakonduri